Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove client monitoring #385

Closed
lenny-goodell opened this issue Jun 19, 2020 · 0 comments · Fixed by #386
Closed

Remove client monitoring #385

lenny-goodell opened this issue Jun 19, 2020 · 0 comments · Fixed by #386
Assignees
Labels
2-medium priority denoting issues with cross-cutting project impact app-services subsystem_affected for application services hanoi Hanoi release
Milestone

Comments

@lenny-goodell
Copy link
Member

lenny-goodell commented Jun 19, 2020

Per the Core WG 6/18/2020 meeting the active Client Monitoring via polling Consul is to be removed.

This Client Monitoring is setup here:
https://github.com/lenny-intel/app-functions-sdk-go/blob/master/internal/bootstrap/handlers/clients.go#L81

Each new client needs to be changed to just use localURL.New from go-mod-core-contracts for the URL.
Example:
change

		eventClient = coredata.NewEventClient(
			urlclient.New(
				ctx,
				wg,
				registryClient,
				clients.CoreDataServiceKey,
				clients.ApiEventRoute,
				interval,
				config.Clients[common.CoreDataClientName].Url()+clients.ApiEventRoute,
			),
		)

to

		eventClient = coredata.NewEventClient(localURL.New(config.Clients[common.CoreDataClientName].Url() + clients.ApiEventRoute))

Once the changes have been made the following packages can be removed:

  • pkg/urlclient
  • pkg/endpoint

ServiceInfo.ClientMonitor can also be removed

@lenny-goodell lenny-goodell added this to the Hanoi milestone Jun 19, 2020
@lenny-goodell lenny-goodell added 2-medium priority denoting issues with cross-cutting project impact hanoi Hanoi release app-services subsystem_affected for application services labels Jun 19, 2020
@lenny-goodell lenny-goodell self-assigned this Jun 19, 2020
lenny-goodell referenced this issue in lenny-goodell/app-functions-sdk-go Jun 20, 2020
@lenny-goodell lenny-goodell linked a pull request Jun 23, 2020 that will close this issue
12 tasks
lenny-goodell added a commit that referenced this issue Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-medium priority denoting issues with cross-cutting project impact app-services subsystem_affected for application services hanoi Hanoi release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant