refactor(sdk): remove deprecated StoreSecret code

BREAKING CHANGE: remove deprecated StoreSecret code, use SecretProvider Closes: #1224 Signed-off-by: Marc-Philippe Fuller <[email protected]>
edgexfoundry · Jan 9, 2023 · dcbe784 · dcbe784
1 parent e59d3cb
commit dcbe784
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 27 deletions.
diff --git a/internal/app/service.go b/internal/app/service.go
@@ -575,12 +575,6 @@ func (svc *Service) ListenForCustomConfigChanges(configToWatch interface{}, sect
 	return nil
 }
 
-// StoreSecret stores the secret data to a secret store at the specified path.
-func (svc *Service) StoreSecret(path string, secretData map[string]string) error {
-	secretProvider := bootstrapContainer.SecretProviderFrom(svc.dic.Get)
-	return secretProvider.StoreSecret(path, secretData)
-}
-
 // SecretProvider returns the SecretProvider instance
 func (svc *Service) SecretProvider() bootstrapInterfaces.SecretProvider {
 	secretProvider := bootstrapContainer.SecretProviderFrom(svc.dic.Get)

diff --git a/pkg/interfaces/mocks/ApplicationService.go b/pkg/interfaces/mocks/ApplicationService.go
diff --git a/pkg/interfaces/service.go b/pkg/interfaces/service.go
@@ -124,13 +124,6 @@ type ApplicationService interface {
 	// asynchronously to the Edgex MessageBus on the specified topic.
 	// Not valid for use with the HTTP or External MQTT triggers
 	AddBackgroundPublisherWithTopic(capacity int, topic string) (BackgroundPublisher, error)
-	// StoreSecret stores the specified secret data into the secret store (secure only) for the specified path
-	// An error is returned if:
-	//   - Specified secret data is empty
-	//   - Not using the secure secret store, i.e. not valid with InsecureSecrets configuration
-	//   - Secure secret provider is not properly initialized
-	//   - Connection issues with Secret Store service.
-	StoreSecret(path string, secretData map[string]string) error // LoggingClient returns the Logger client
 	// SecretProvider returns the SecretProvider instance
 	SecretProvider() bootstrapInterfaces.SecretProvider
 	// LoggingClient returns the Logger client