Revise: fix QString::split(...) for older Qt Versions #113
Conversation
A use of the above in the test code fails to build on anything older than Qt 5.14 as the `enum` used is only present in that and newer versions. Previously the `enum` was a member of the `QString` class rather than the `Qt` namespace... Signed-off-by: Stephen Lyons <[email protected]>
|
For some reason the CI tests (that the Mudlet team inserted into the code base in 47f970c) on Linux run against Qt 5.6 (it seems) so are thus borked currently... |
|
@gamecreature What is the minimum Qt version that you intend (or would like) the |
|
Thank you!! |
Well, it might be worth coding to at lest consider the oldest current LTS version (currently that is QT 5.12.8 IIRC with an EOL 2020/12/05)... https://en.wikipedia.org/wiki/Qt_version_history#Qt_5 is probably worth bookmarking... |
|
@SlySven I agree on this. I think LTS is a good lowest version to aim for. (Sorry for the late response). |
A use of the above in the test code fails to build on anything older than Qt 5.14 as the
enumused is only present in that and newer versions. Previously theenumwas a member of theQStringclass rather than theQtnamespace...Signed-off-by: Stephen Lyons [email protected]