Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources acquired but not released #94

Closed
vadi2 opened this issue Aug 16, 2019 · 4 comments
Closed

Resources acquired but not released #94

vadi2 opened this issue Aug 16, 2019 · 4 comments

Comments

@vadi2
Copy link
Contributor

vadi2 commented Aug 16, 2019

Check out this lgtm query for resources acquired but not released in destructor: https://lgtm.com/query/4595774969870185531/

Seems like a low issue, but an issue nonetheless?

@gamecreature
Copy link
Member

I have't touched the TextLineData resource issue. It seems to be intentionally that way:

TextLineDataList::~TextLineDataList()
{
if( lineDataList_ ) {
// Q_ASSERT(false); /// YOU MUST call destroy before the destructor!
qlog_warn() << "** Warning TextLineDataList requires manual destruction! ** ";
}

@vadi2
Copy link
Contributor Author

vadi2 commented Aug 27, 2019

Not sure what that means. Is that an issue in edbee or mudlet's use of it?

@gamecreature
Copy link
Member

Does Mudlet use custom TextLineData items?
If not you can ignore it...

I don't really know anymore why this is done this way.

@vadi2
Copy link
Contributor Author

vadi2 commented Aug 27, 2019

I don't think so. OK, thanks for looking at this :)

@vadi2 vadi2 closed this as completed Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants