Added implementations of continous test functions #67
Conversation
…ons_refactor # Conflicts: # src/main.rs
…ency, added exceptions to functions that work only in a limited number of dimensions.
Co-authored-by: Kacper Ślusarczyk <[email protected]>
Co-authored-by: Kacper Ślusarczyk <[email protected]>
| @@ -0,0 +1 @@ | |||
| pub mod test_functions; | |||
There was a problem hiding this comment.
Missing new line at the file end.
For some reason I do not have option to "suggest changes" (I don't see such button :D), so I'm just leaving descriptions.
| if x.len() < 1 { | ||
| panic!("Rastrigin function takes an at least one dimensional vector as a parameter."); | ||
| } |
There was a problem hiding this comment.
It would be more clear to just use assert! macro here.
This can be applied to parameter validation you did in every of the implemented functions.
| panic!("Rastrigin function takes an at least one dimensional vector as a parameter."); | ||
| } | ||
| let mut result: f64 = 0.0; | ||
| for x_curr in x.iter() { |
There was a problem hiding this comment.
I believe using .iter() explicitly here is not necessary. Compiler will deduce this on its own.
This can be applied in few more places.
| let x1 = x[0]; | ||
| let x2 = x[1]; | ||
| let mut result: f64 = 0.0; | ||
| result += f64::sin(x1 + x2); | ||
| result += f64::powi(x1 - x2, 2); | ||
| result += -1.5 * x1; | ||
| result += 2.5 * x2; | ||
| result += 1.0; | ||
| return result; |
There was a problem hiding this comment.
I believe we can omit creating result variable completely here.
| let mut result: f64; | ||
| result = -1.0 * f64::abs(f64::sin(x1) * f64::cos(x2) * f64::exp(f64::abs(1.0 - f64::sqrt(f64::powi(x1, 2) + f64::powi(x2, 2)) / f64::consts::PI))); | ||
| return result; |
There was a problem hiding this comment.
We can omit creating result variable here, and in few more places.
Description
Added implementations of continous test functions
Linked issues
closes #17