Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pool: ArenaPool 基于实验特性 arena 的对象池 #160

Merged
merged 10 commits into from
Mar 14, 2023
Merged

pool: ArenaPool 基于实验特性 arena 的对象池 #160

merged 10 commits into from
Mar 14, 2023

Conversation

jason12360
Copy link
Contributor

  • GET,PUT,FREE
  • 暂时不支持并发

@jason12360
完成areapool的最基本功能
0491aa2 
- GET,PUT,FREE
- 暂时不支持并发
@jason12360 jason12360 closed this Mar 4, 2023
@jason12360 jason12360 changed the title 完成areapool的最基本功能 WIP:完成areapool的最基本功能 Mar 4, 2023
@jason12360 jason12360 reopened this Mar 4, 2023
flycash
flycash requested changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把它做成线程安全的，然后后面我们考虑替换成在 list 里面实现的无锁的 list 来放所有的元素

flycash
flycash reviewed Mar 6, 2023
View reviewed changes
@flycash
Copy link
Contributor

flycash commented Mar 6, 2023

后续要考虑：

  • 性能测试。目前来看最简单的并发做法就是读写锁
  • 内存使用量控制，以及相应的淘汰设计
  • 可观测性，即暴露内部缓存了多少元素，占用了多少空间之类的

flycash
flycash reviewed Mar 6, 2023
View reviewed changes
flycash
flycash reviewed Mar 9, 2023
View reviewed changes
Copy link
Contributor

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你是忘记推代码了？

@codecov
Copy link

codecov bot commented Mar 13, 2023 •
edited
Loading

Codecov Report

Merging #160 (3793a5b) into dev (a86c451) will increase coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #160      +/-   ##
==========================================
+ Coverage   95.74%   96.00%   +0.26%     
==========================================
  Files          41       41              
  Lines        2280     2280              
==========================================
+ Hits         2183     2189       +6     
+ Misses         77       73       -4     
+ Partials       20       18       -2

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

flycash
flycash requested changes Mar 13, 2023
View reviewed changes
@flycash flycash changed the title WIP:完成areapool的最基本功能 pool: ArenaPool 基于实验特性 arena 的对象池 Mar 13, 2023
flycash
flycash requested changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 在 .Changelog 里面加一条，把这个合并请求加进去
  • 执行一下 make check，主要就是要格式化一下代码

@flycash flycash merged commit 25821e9 into ecodeclub:dev Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flycash flycash flycash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jason12360 @flycash