Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level float attributes #207

Closed

Conversation

point9repeating
Copy link

Read level, topLevel and bottomLevel attributes as float if key_type is not specified. Convert back to int (the previous default) if the value is an integer.

fixes #195

@FussyDuck
Copy link

FussyDuck commented Mar 4, 2021

CLA assistant check
All committers have signed the CLA.

@alexamici
Copy link
Contributor

@point9repeating thanks for the contribution!

Special casing the level keys in the message_get code path feel a bit too specific for my taste, so I'd prefer not to merge the PR as is.

We are looking into adding a way to specify the key type for coordinates and then using float as the default value for level keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GFS: Missing levels for sigmaLayer and depthBelowLandLayer
3 participants