This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Support masking of unconnected nodes (LAM) #171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
b8raoult
previously approved these changes
Nov 28, 2024
…ecmwf/anemoi-training into feature/support-lam-without-unconnected
for more information, see https://pre-commit.ci
…ecmwf/anemoi-training into feature/support-lam-without-unconnected
theissenhelen
suggested changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a typo to fix.
theissenhelen
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using masked graphs, resulting in a performance improvement in LAM by dropping unused nodes in the boundary forcing dataset.
Description
The current release of anemoi-graphs (
0.4.1
) supports dropping unconnected nodes from the limited area graph, with the following code:anemoi-graphs
returns the masked graph with an additional node attributeindices_connected_nodes
(in this example) representing the indices used to mask the input dataset to the new graphdata
nodes.Solution
We need to specify these spatial indices in the dataloader config.
The performance improvement is of 66 % (from 1,92 it/s to 3,19 it/s) for the 1 GPU default limited area model.
This PR has been tested successfully on 1 GPU (with
plot: detailed
withoutPlotSpectrum
included):reader_group_size=1
reader_group_size=1
reader_group_size=1
This PR has been tested successfully on 2 GPU (with
plot: detailed
withoutPlotSpectrum
included):reader_group_size=2
reader_group_size=2
reader_group_size=2
W.I.P.: This mask must be saved to the checkpoint so that it can be used in
anemoi-inference
.