Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make frozendict picklable #69

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Make frozendict picklable #69

merged 1 commit into from
Dec 5, 2024

Conversation

tmi
Copy link
Collaborator

@tmi tmi commented Dec 3, 2024

Replaces frozendict implementation by existing stdlib thing which behaves more or less the same, but coops with pickle

I've tested like d = frozendict({'a': 4}) and d['a'] == 4 and d['a'] = 5 # raises and del d['a'] # raises and d['b'] = 7 # raises. Are there any other cases of interest?

(ftr I put no changelog here, this should have no outwardly visible effect)

* Replace frozendict implementation by existing stdlib thing
  which behaves more or less the same, but coops with pickle
@FussyDuck
Copy link

FussyDuck commented Dec 3, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.00%. Comparing base (91b104a) to head (0a1c262).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #69   +/-   ##
========================================
  Coverage    75.00%   75.00%           
========================================
  Files            1        1           
  Lines            4        4           
========================================
  Hits             3        3           
  Misses           1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@b8raoult b8raoult merged commit 62fff47 into develop Dec 5, 2024
118 of 122 checks passed
@b8raoult b8raoult deleted the bug/frozendictPickling branch December 5, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants