Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): Add accumulate_from_start_of_forecast post-processor #133

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

gmertes
Copy link
Member

@gmertes gmertes commented Feb 11, 2025

Implements step 1 and 2 of #131

For CLI and OO API users: if post_processors is not defined in the user-config, the current behaviour is to keep accumulating from the beginning of the forecast. A warning is shown to alert users that this will change in the future.

To explicitly turn accumulations from beginning of the forecast on or off, the user can do:

# on
post_processors: 
  - accumulate_from_start_of_forecast
# off
post_processors: []

For the numpy-to-numpy API it is turned off by default.

@gmertes gmertes requested a review from b8raoult February 11, 2025 12:39
@github-actions github-actions bot added the enhancement New feature or request label Feb 11, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.07%. Comparing base (90728d5) to head (09b7b13).
Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
- Coverage   98.03%   96.07%   -1.97%     
==========================================
  Files           3        3              
  Lines          51       51              
==========================================
- Hits           50       49       -1     
- Misses          1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmertes gmertes added the config label Feb 11, 2025
@github-actions github-actions bot removed the config label Feb 11, 2025
@gmertes gmertes changed the title feat(config): Add accumulate_from_start_of_forecast post-processor feat(config): Add accumulate_from_start_of_forecast post-processor (#131) Feb 11, 2025
@gmertes gmertes changed the title feat(config): Add accumulate_from_start_of_forecast post-processor (#131) feat(config): Add accumulate_from_start_of_forecast post-processor Feb 11, 2025
@gmertes gmertes added the config label Feb 11, 2025
@github-actions github-actions bot removed the config label Feb 11, 2025
@gmertes gmertes merged commit 527517c into main Feb 11, 2025
75 checks passed
@gmertes gmertes deleted the feat/accumulate_from_start branch February 11, 2025 13:06
@gmertes gmertes added the config label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants