Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for key binding, contributions and registry #10

Closed
wants to merge 1 commit into from

Conversation

JonasHelming
Copy link
Member

Contributed on behalf of STMicroelectronics

Signed-off-by: Jonas Helming [email protected]

What it does

How to test

Review checklist

Reminder for reviewers

packages/core/src/browser/keybinding.ts Outdated Show resolved Hide resolved
packages/core/src/browser/keybinding.ts Outdated Show resolved Hide resolved
packages/core/src/browser/keybinding.ts Outdated Show resolved Hide resolved
packages/core/src/browser/keybinding.ts Show resolved Hide resolved
packages/core/src/common/keybinding.ts Outdated Show resolved Hide resolved
packages/core/src/common/keybinding.ts Outdated Show resolved Hide resolved
Copy link
Member

@koegel koegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes required

packages/core/src/common/keybinding.ts Outdated Show resolved Hide resolved
packages/core/src/common/keybinding.ts Outdated Show resolved Hide resolved
@tortmayr tortmayr self-requested a review October 7, 2020 08:00
fixes eclipse-theia#8636

Contributed on behalf of STMicroelectronics

Signed-off-by: Jonas Helming <[email protected]>
@sdirix
Copy link
Member

sdirix commented Nov 16, 2022

Merged upstream with eclipse-theia#8637

@sdirix sdirix closed this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants