Add possibility to build images from "dockerfiles" folder with '--no-cache' option #14213

Ohrimenko1988 · 2019-08-13T12:44:18Z

Signed-off-by: Ihor Okhrimenko [email protected]

What does this PR do?

Add possibility to build images from "dockerfiles" folder with '--no-cache' option

What issues does this PR fix or reference?

Issue: #14212

Release Notes

Docs PR

Signed-off-by: Ihor Okhrimenko <[email protected]>

che-bot · 2019-08-13T13:01:44Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14213

benoitf · 2019-08-13T13:44:09Z

dockerfiles/e2e/build.sh

@@ -20,7 +20,7 @@ fi
 echo "Copying source code ${E2E_DIR} --> ${LOCAL_E2E_DIR}"
 cp -r "${E2E_DIR}" "${LOCAL_E2E_DIR}"

-init --name:e2e "$@"
+init --name:e2e --no-cache "$@"


I think there is something wrong here. Why no-cache should be mandatory if not given in build args ?

@benoitf If I understand you correctly, you mean common "build.sh". But this is not common "build.sh", this is "build.sh" of the e2e tests image, and for this image, we exactly need "--no-cache" option by default.

There is something wrong in the Dockerfile if it should be default. I'm -1

@benoitf The thing is, that we are installing latest chrome from official google chrome repo in the image (here), but as the dockerfile is not changing and the build is happening everytime on the same machine, cache is used and we are stuck with old version of browser.
I'm not aware of any other way of solving this. If you have better idea how to solve this, we're all ears!

Even in official docker best practices is this section in one of the examples:

# Install tools required to build the project # We will need to run `docker build --no-cache .` to update those dependencies RUN apk add --no-cache git RUN go get github.com/golang/dep/cmd/dep

@rhopp
to sum up: you want to invalidate the cache only if chome is updated

The approach for this is to use an ADD instruction to a link that is updated when google chrome is updated

Then you should (maybe link is not correct) use instruction like

# invalidate cache if updated ADD http://dl.google.com/linux/chrome/rpm/stable/x86_64/repodata/filelists.xml.gz /tmp/filelists.xml.gz

before the yum install instructions

so it means that if the google chrome is not updated then we keep the layers, if google chrome is updated then layers are automatically invalidated

This is what we're doing in some Dockerfile to only recompile a dependency if github project has new commits since the last time we ran docker build

Sounds good. Will try that! Thanks!

Signed-off-by: Ihor Okhrimenko <[email protected]>

che-bot · 2019-08-19T07:53:49Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14213
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-08-19T08:33:32Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14213
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Ihor Okhrimenko <[email protected]>

…cache

Signed-off-by: Ihor Okhrimenko <[email protected]>

…cache

che-bot · 2019-08-22T15:00:30Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14213

che-bot · 2019-08-22T15:20:45Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14213

che-bot · 2019-08-22T16:22:40Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14213
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Ihor Okhrimenko <[email protected]>

che-bot · 2019-08-23T10:34:25Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14213

Signed-off-by: Ihor Okhrimenko <[email protected]>

che-bot · 2019-08-23T11:06:35Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14213

che-bot · 2019-08-23T11:35:16Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:14213

rhopp

I thought we decided to scratch the --no-cache option from build.include and implement some logic into dockerfile (based on Florent's suggestion). What's the status of that?

dockerfiles/e2e/Dockerfile

dockerfiles/e2e/entrypoint.sh

dockerfiles/e2e/Dockerfile

dockerfiles/e2e/entrypoint.sh

Signed-off-by: Ihor Okhrimenko <[email protected]>

Katka92 · 2019-08-27T13:09:36Z

dockerfiles/e2e/README.md

@@ -30,11 +30,11 @@ If you want to gather screenshots of fallen tests, you have to mount a volume to
 a command:

 ```
-docker run --shm-size=256m -v /full/path/to/your/folder:/root/e2e/report:Z -e THEIA_SELENIUM_BASE_URL=$URL eclipse/che-e2e:nightly
+docker run --shm-size=256m -v /full/path/to/your/folder:/root/e2e/report -e THEIA_SELENIUM_BASE_URL=$URL eclipse/che-e2e:nightly


Why did you removed the :Z from here?

Signed-off-by: Ihor Okhrimenko <[email protected]>

che-bot · 2019-08-27T13:54:21Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:14213

che-bot · 2019-08-27T14:05:11Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14213

dmytro-ndp · 2019-08-27T14:29:15Z

IMHO, it makes sense to get rid of "--no-cache" option from dockerfiles/build.include, as Radim suggested above.

Signed-off-by: Ihor Okhrimenko <[email protected]>

dmytro-ndp

Looks good.

che-bot · 2019-08-27T14:43:41Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14213

che-bot · 2019-08-27T15:13:36Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:14213

…ests were changed. Related PR: eclipse-che/che#14213

…ests were changed. Related PR: eclipse-che/che#14213 (#1577)

…ests were changed. Related PR: eclipse-che/che#14213 (redhat-developer#1577)

…ests were changed. Related PR: eclipse-che/che#14213 (#1577)

Add '--no-cache' argument

0ceb852

Signed-off-by: Ihor Okhrimenko <[email protected]>

Ohrimenko1988 requested review from benoitf, l0rd, nickboldt and rhopp as code owners August 13, 2019 12:44

che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Aug 13, 2019

benoitf reviewed Aug 13, 2019

View reviewed changes

Intermediate changes

c0df3db

Signed-off-by: Ihor Okhrimenko <[email protected]>

Ohrimenko1988 added 4 commits August 21, 2019 09:32

Intermediate changes

881abe8

Signed-off-by: Ihor Okhrimenko <[email protected]>

Merge branch 'master' of https://github.com/eclipse/che into selen-no…

40e7ccb

…cache

Rewrite e2e dockerfile

a447893

Signed-off-by: Ihor Okhrimenko <[email protected]>

Add entrypoint script

f8ae0c5

Signed-off-by: Ihor Okhrimenko <[email protected]>

Ohrimenko1988 requested a review from musienko-maxim as a code owner August 22, 2019 14:41

Ohrimenko1988 added 2 commits August 22, 2019 17:45

Remove outdated entrypoint script

45e3165

Signed-off-by: Ihor Okhrimenko <[email protected]>

Merge branch 'master' of https://github.com/eclipse/che into selen-no…

37a1495

…cache

Add cleanup docker script

45a64e8

Signed-off-by: Ihor Okhrimenko <[email protected]>

Merger master and resolve conflicts

1ea8dfd

Signed-off-by: Ihor Okhrimenko <[email protected]>

rhopp reviewed Aug 23, 2019

View reviewed changes

dockerfiles/e2e/Dockerfile Outdated Show resolved Hide resolved

rhopp reviewed Aug 23, 2019

View reviewed changes

dockerfiles/e2e/entrypoint.sh Outdated Show resolved Hide resolved

Katka92 reviewed Aug 27, 2019

View reviewed changes

dockerfiles/e2e/entrypoint.sh Outdated Show resolved Hide resolved

dockerfiles/e2e/Dockerfile Outdated Show resolved Hide resolved

dockerfiles/e2e/entrypoint.sh Outdated Show resolved Hide resolved

Ohrimenko1988 added 3 commits August 27, 2019 15:47

Do changes according to review

8250934

Signed-off-by: Ihor Okhrimenko <[email protected]>

Do changes according to review

f5ab4c8

Signed-off-by: Ihor Okhrimenko <[email protected]>

Add description to the "README.md"

e410128

Signed-off-by: Ihor Okhrimenko <[email protected]>

Katka92 requested changes Aug 27, 2019

View reviewed changes

Fix typo

b36a067

Signed-off-by: Ihor Okhrimenko <[email protected]>

Katka92 approved these changes Aug 27, 2019

View reviewed changes

SkorikSergey approved these changes Aug 27, 2019

View reviewed changes

artaleks9 approved these changes Aug 27, 2019

View reviewed changes

Do changes according to review

6dba734

Signed-off-by: Ihor Okhrimenko <[email protected]>

dmytro-ndp reviewed Aug 27, 2019

View reviewed changes

dmytro-ndp approved these changes Aug 27, 2019

View reviewed changes

Ohrimenko1988 merged commit e8efb82 into master Aug 27, 2019

che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 27, 2019

che-bot added this to the 7.1.0 milestone Aug 27, 2019

Ohrimenko1988 mentioned this pull request Aug 28, 2019

Reconfigure existed CI jobs for using "eclipse/che-e2e:nightly" image #14346

Closed

Ohrimenko1988 deleted the selen-nocache branch August 28, 2019 07:26

Katka92 added a commit to Katka92/rh-che that referenced this pull request Aug 28, 2019

Breaking changes done in upstream, fixing. The mount destination of t…

fda0fe6

…ests were changed. Related PR: eclipse-che/che#14213

Katka92 added a commit to Katka92/rh-che that referenced this pull request Aug 28, 2019

Breaking changes done in upstream, fixing. The mount destination of t…

1e99183

…ests were changed. Related PR: eclipse-che/che#14213

Katka92 mentioned this pull request Aug 28, 2019

Fixing docker build redhat-developer/rh-che#1577

Merged

Katka92 added a commit to redhat-developer/rh-che that referenced this pull request Aug 29, 2019

Breaking changes done in upstream, fixing. The mount destination of t…

43a1007

…ests were changed. Related PR: eclipse-che/che#14213 (#1577)

Katka92 added a commit to Katka92/rh-che that referenced this pull request Sep 3, 2019

Breaking changes done in upstream, fixing. The mount destination of t…

7cf56f5

…ests were changed. Related PR: eclipse-che/che#14213 (redhat-developer#1577)

ibuziuk pushed a commit to redhat-developer/rh-che that referenced this pull request Sep 6, 2019

Breaking changes done in upstream, fixing. The mount destination of t…

3e8bc8e

…ests were changed. Related PR: eclipse-che/che#14213 (#1577)

ibuziuk pushed a commit to redhat-developer/rh-che that referenced this pull request Sep 6, 2019

Breaking changes done in upstream, fixing. The mount destination of t…

e61e24d

…ests were changed. Related PR: eclipse-che/che#14213 (#1577)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add possibility to build images from "dockerfiles" folder with '--no-cache' option #14213

Add possibility to build images from "dockerfiles" folder with '--no-cache' option #14213

Ohrimenko1988 commented Aug 13, 2019

che-bot commented Aug 13, 2019

benoitf Aug 13, 2019

Ohrimenko1988 Aug 14, 2019 •

edited

Loading

benoitf Aug 14, 2019

rhopp Aug 14, 2019

rhopp Aug 14, 2019

benoitf Aug 14, 2019 •

edited

Loading

benoitf Aug 14, 2019

rhopp Aug 14, 2019

che-bot commented Aug 19, 2019

che-bot commented Aug 19, 2019

che-bot commented Aug 22, 2019

che-bot commented Aug 22, 2019

che-bot commented Aug 22, 2019

che-bot commented Aug 23, 2019

che-bot commented Aug 23, 2019

che-bot commented Aug 23, 2019

rhopp left a comment

Katka92 Aug 27, 2019

che-bot commented Aug 27, 2019

che-bot commented Aug 27, 2019

dmytro-ndp commented Aug 27, 2019

dmytro-ndp left a comment

che-bot commented Aug 27, 2019

che-bot commented Aug 27, 2019

Add possibility to build images from "dockerfiles" folder with '--no-cache' option #14213

Add possibility to build images from "dockerfiles" folder with '--no-cache' option #14213

Conversation

Ohrimenko1988 commented Aug 13, 2019

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Docs PR

che-bot commented Aug 13, 2019

benoitf Aug 13, 2019

Choose a reason for hiding this comment

Ohrimenko1988 Aug 14, 2019 • edited Loading

Choose a reason for hiding this comment

benoitf Aug 14, 2019

Choose a reason for hiding this comment

rhopp Aug 14, 2019

Choose a reason for hiding this comment

rhopp Aug 14, 2019

Choose a reason for hiding this comment

benoitf Aug 14, 2019 • edited Loading

Choose a reason for hiding this comment

benoitf Aug 14, 2019

Choose a reason for hiding this comment

rhopp Aug 14, 2019

Choose a reason for hiding this comment

che-bot commented Aug 19, 2019

che-bot commented Aug 19, 2019

che-bot commented Aug 22, 2019

che-bot commented Aug 22, 2019

che-bot commented Aug 22, 2019

che-bot commented Aug 23, 2019

che-bot commented Aug 23, 2019

che-bot commented Aug 23, 2019

rhopp left a comment

Choose a reason for hiding this comment

Katka92 Aug 27, 2019

Choose a reason for hiding this comment

che-bot commented Aug 27, 2019

che-bot commented Aug 27, 2019

dmytro-ndp commented Aug 27, 2019

dmytro-ndp left a comment

Choose a reason for hiding this comment

che-bot commented Aug 27, 2019

che-bot commented Aug 27, 2019

Ohrimenko1988 Aug 14, 2019 •

edited

Loading

benoitf Aug 14, 2019 •

edited

Loading