Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace macos-latest with macos-13 and macos-14 runners #935

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

fuzzypixelz
Copy link
Member

@fuzzypixelz fuzzypixelz commented Apr 15, 2024

Clippy from Rust 1.77.2 has been failing on maco-latest for a while. I suspect it might have something to do with rust-lang/rust#92173. Except in our case the failure happens 100% of the time and is not sporadic.

What I know so far:

  1. Even though we specify macos-latest, GitHub simply uses macos-12 images, for some reason I'm not too keen on knowing.
  2. The command that fails is cargo +stable clippy --all-targets and not cargo +stable build --all-targets and not cargo +stable clippy.
  3. Every time clippy fails out of a SIGABRT, it's because of failure to compile some zenoh crate, often for test targets. It seems that this can be any crate, which helps the hypothesis that this is a sporadic failure made worse by zenoh having 34 crates.
  4. I cannot reproduces this on macOS 13, neither on AArch64 nor on x86_64.

This pull request tries to force GitHub to give us macOS 13/14 to see what happens. The idea is that Rust 1.77.2 doesn't play too nicely with the C runtime in macOS 12, which would explain why it doesn't fail on macOS 13 or 14 for me (locally).

@fuzzypixelz
Copy link
Member Author

fuzzypixelz commented Apr 15, 2024

Okay. Clippy 1.77.2 fails on macOS 12 but works on macOS 13 and 14. GitHub is not supposed to be swapping macOS 14 for macOS 12. They should update their documentation.

I'm just going to keep both macOS 13 and 14 because if we can trust the GitHub docs macos-14 runners are M1 machines, which would be useful for running tests on AArch64 in the CI as it won't impact the execution time.

At the time of committing, maco-latest is just macos-12.
@fuzzypixelz fuzzypixelz changed the title wip: Test check job on macOS 12, 13 and 14 fix: Replace macos-latest with macos-13 and macos-14 runners Apr 15, 2024
@fuzzypixelz
Copy link
Member Author

fuzzypixelz commented Apr 16, 2024

GitHub is in the process of migrating macos-latest to use macos-14. There was no mention of this in the docs though...

@Mallets
Copy link
Member

Mallets commented Apr 16, 2024

@fuzzypixelz should we merge this PR for the time being or should we wait for the migration?

@fuzzypixelz
Copy link
Member Author

@fuzzypixelz should we merge this PR for the time being or should we wait for the migration?

I think we can just merge it. We'd like to have both macOS 13 and 14 anyway.

@Mallets Mallets merged commit 4aa6e3d into eclipse-zenoh:main Apr 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants