updated generation of AbstractLanguageServerTest #3333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Dietrich <[email protected]>
|
@LorenzoBettini @szarnekow is this file dirty for you too? |
|
@cdietrich That happens when you use Java 21, I guess because of the different hierarchy structure. Unfortunately, we should use Java 21 to run Eclipse and most of the UI tests. However, we target Java 17, so such dirty files should be reverted instead of committed. At least, that's what I always do. I guess it's also safe to commit them; in the end, it's up to us. |
|
i see, so i will try on different pc with older tp.... |
no need to: it only gets regenerated in clean builds; if you revert it, it will stay the same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.