Fixes #342: Run surefire tests outside of lock #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running tests while the lock is present leads to the tests being executed in series which severely degrades performance when the build is running with parallel maven projects.
laeubi
approved these changes
Nov 25, 2021
|
Thanks for the change. Just a note: You have created your PR from your forks master branch, it is often more desirable to create a branch for the feature and just name it e.g. issue_nnn_description that way you can for example always sync with the master repository if required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running tests while the lock is present leads to the tests being executed in series which severely degrades performance when the build is running with parallel maven projects.