Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images for social preview #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Images for social preview #9

wants to merge 1 commit into from

Conversation

egekorkan
Copy link
Member

Until the moment I have created this PR, I was thinking I was fixing eclipse-thingweb/website#118 but realized that it is about the website's social preview and not the repositories... Anyways, I think that this is still useful :D I am changing the repo options already, let's see what happens.

@egekorkan
Copy link
Member Author

See also
image

@danielpeintner
Copy link
Member

danielpeintner commented Feb 5, 2025

Mhh, I am not 100% sure why we have this additional social images.

Compared to https://github.com/eclipse-thingweb/thingweb/blob/main/brand/logos/thingweb.svg the only difference is padding/margin around it, right? In HTML, you can, and maybe should, specify it via CSS...

EDIT: Moreover, different social platforms will most likely have different required properties.

@egekorkan
Copy link
Member Author

egekorkan commented Feb 5, 2025

Mhh, I am not 100% sure why we have this additional social images.

Compared to https://github.com/eclipse-thingweb/thingweb/blob/main/brand/logos/thingweb.svg the only difference is padding/margin around it, right? In HTML, you can, and maybe should, specify it via CSS...

EDIT: Moreover, different social platforms will most likely have different required properties.

Sorry for not including the context... Once you click edit, you get a template that looks like this:

repository-open-graph-template

I think different platforms still need an image like this. I guess the padding is there to have some tolerance

@relu91
Copy link
Member

relu91 commented Feb 5, 2025

What about something like this?
image

I would try to make it more catchy, icons and text TBD.

@egekorkan
Copy link
Member Author

That would be even nicer

@relu91 relu91 added the Discuss in Committer Meeting Labels issues and PRs that should be discussed in our regular Thingweb Committer Meeting. label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discuss in Committer Meeting Labels issues and PRs that should be discussed in our regular Thingweb Committer Meeting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants