feat: allow to process AID submodel only #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sebastiankb you should be able to test this locally with
|
sebastiankb
reviewed
Dec 13, 2022
| @@ -125,7 +153,7 @@ class AssetInterfaceDescriptionUtilTest { | |||
| .to.have.lengthOf(1); | |||
|
|
|||
| // filter Modbus and HTTP and submodel only | |||
| const td3 = this.assetInterfaceDescriptionUtil.transformToTD(modelAID, `{"title": "myTitle"}`, "Modbus|HTTP"); | |||
| const td3 = this.assetInterfaceDescriptionUtil.transformAAS2TD(modelAID, `{"title": "myTitle"}`, "Modbus|HTTP"); | |||
There was a problem hiding this comment.
is it also possible to filter by interface name?
There was a problem hiding this comment.
I think that's what it is doing...
We currently have for example the following term in JSON
"idShort": "Interface1 (Modbus; s. slides from 21.6.2022)"
The regex "Modbus|HTTP" looks into this idShort and tries to find either Modbus or HTTP...
One could also use "Interface1" for the regex to select Modbus.
There was a problem hiding this comment.
ok, perfect. From my view we can merge this PR
danielpeintner
changed the title
sebastiankb
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #888