Fix receiving of MQTT commands #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctron
force-pushed
the
feature/fix_mqtt_1
branch
from
34c25ae to
78bb3b3
Compare
relu91
reviewed
Nov 21, 2022
|
@ctron may I ask you to merge in master so that we get rid of the CI test issues we had since some days. Thanks! |
|
FYI: I merged master in to get a clean run. @relu91 I let you decide w.r.t. #875 (review) |
Receiving of MQTT commands is currently broken. The reason for this is, that the callback is registered in a way that the "this" context is dropped. Also see: https://stackoverflow.com/questions/20279484/how-to-access-the-correct-this-inside-a-callback
relu91
force-pushed
the
feature/fix_mqtt_1
branch
from
73289fc to
a8b50ae
Compare
|
I rebased and fixed the commit, merging when CI is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Receiving of MQTT commands is currently broken. The reason for this is, that the callback is registered in a way that the "this" context is dropped.
Also see: https://stackoverflow.com/questions/20279484/how-to-access-the-correct-this-inside-a-callback