Fix the build by locking versions during the container build #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the lock file to the build container, to use the expected versions and not let the build process select newer ones. I believe this is ok, as the container build already selects a fixed build and runtime container tag. So the content of the container should be much more predictable. This also adds full container names instead of shortnames. Closes: eclipse-thingweb#870
relu91
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the lock file to the build container, to use the expected versions and not let the build process select newer ones.
I believe this is ok, as the container build already selects a fixed build and runtime container tag. So the content of the container should be much more predictable.
This also adds full container names instead of shortnames.
Closes: #870