Support observeProperty in binding-firestore #808
Conversation
hidetak
changed the title
| @@ -74,7 +74,7 @@ export const writeDataToFirestore = async ( | |||
| content: Content, | |||
| reqId: string = null | |||
| ): Promise<void> => { | |||
| console.debug("[debug] writeDataToFirestore topic:", topic, " value:", content, reqId); | |||
| console.debug("[debug] writeDataToFirestore topic:", topic, reqId); | |||
There was a problem hiding this comment.
We seemed to have missed it before but we usually add the "protocol" so that we know where the log comes from and we can filter it..
e.g., console.debug("[binding-http]", HttpServer ...);
Do you think we can do this for firestore too?
There was a problem hiding this comment.
Thank you for giving comment !
Looks good but I added a logging comment and wanted to ask you about resolving warnings like
"Unexpected any. Specify a different type".
How can I check the above message?
Do you think we can do this for firestore too?
OK. I will modify the log to output [binding-firestore].
There was a problem hiding this comment.
Looks good but I added a logging comment and wanted to ask you about resolving warnings like
"Unexpected any. Specify a different type".How can I check the above message?
Visual Studio code should show you these warnings.
Besides that, running npm run lint in the root folder or for example in packages/binding-firestore will show you these warnings as well.
Moreover, the "Files changed" tab of Github highlights the same issues
Do you think we can do this for firestore too?
OK. I will modify the log to output
[binding-firestore].
👍
There was a problem hiding this comment.
W.r.t. debugging.
We are about to change debug module for logging.
see #783
There was a problem hiding this comment.
LGTM.
We can update the logging in a follow-up PR.
Note: we are bout to change logging to use the debug library.
@relu91 any concerns before merging?
|
checked with @relu91. Good to go. |
|
@danielpeintner |
|
@hidetak thank you for your contribution. |
I was able to deal with it only by modifying the test, example code and README.