fix: return the object as described in the TD #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MartinMeyer1 <[email protected]>
|
I can't get why this doesn't work on windows, as it worked before the "Correct coding style" commit... |
|
I think the issue should be unrelated to this PR and hopefully be fixed by #782. |
danielpeintner
approved these changes
Jun 7, 2022
|
@MartinMeyer1 can you merge in the changes from master... |
danielpeintner
requested changes
Jun 7, 2022
Signed-off-by: MartinMeyer1 <[email protected]>
…into fix-jsoncodec-value-property
danielpeintner
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The json codec returned the value corresponding to the key "value" of the readed property, instead of the full json object as expected and described in the TD.
Signed-off-by: MartinMeyer1 [email protected]