Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase version to 0.8.1 and fix dependency issues with TMs, CoAP, OPC-UA #727

Merged

Conversation

danielpeintner
Copy link
Member

No description provided.

@danielpeintner danielpeintner changed the title chore: increase version to 8.0.1 chore: increase version to 0.8.1 Mar 31, 2022
@danielpeintner
Copy link
Member Author

@relu91 others
shall we merge this PR "as is" and integrate the CoAP and OPC-UA fixes in a follow-up PR?

@erossignon
Copy link
Contributor

I would not merge this PR without fixing the 2 issues first, commenting tests out is not a good idea;

@danielpeintner
Copy link
Member Author

I would not merge this PR without fixing the 2 issues first, commenting tests out is not a good idea;

@erossignon Thanks for the fix!

I do have some questions now

  • how could that happen?
    • shouldn't minor version changes be backwards compatible?
    • why does npm install not refresh all dependencies (needs to remove package-lock.json first?)
  • how can we prevent this from happening again (create a fresh package-lock.json file from time to time?)
  • might users of node-wot encounter issues with the recent release v0.8.0? Shall we release a bug-fix release soon?

@danielpeintner danielpeintner changed the title chore: increase version to 0.8.1 chore: increase version to 0.8.1 and fix dependency issues with TMs, CoAP, OPC-UA Apr 1, 2022
@relu91
Copy link
Member

relu91 commented Apr 1, 2022

shouldn't minor version changes be backwards compatible?

IMHO, they should but not everybody follows this convention 😢

why does npm install not refresh all dependencies (needs to remove package-lock.json first?)

Maybe npm-update what we are looking for.

how can we prevent this from happening again (create a fresh package-lock.json file from time to time?)

my takeaway from this experience is that before release we should update all the dependencies to the latest version. In my understanding dependants libraries will not follow the package-lock constraints and if they install node-wot right after the release they will download the latest version of our dependencies.

might users of node-wot encounter issues with the recent release v0.8.0? Shall we release a bug-fix release soon?

I did some tests locally and I didn't encounter any problems. But I'm not against to have more frequent releases 👍🏻

@danielpeintner
Copy link
Member Author

I suggest to wait for coapjs/node-coap#333 to land. This would bring as back to "normal" again

@danielpeintner
Copy link
Member Author

danielpeintner commented Apr 8, 2022

Note: since we are introducing some breaking changes in #731 @relu91 is suggesting to jump to v0.9.0
see #731 (comment)

EDIT: One downside is a bit that we loose the connection between "wot-typescript-definitions" versioning

@JKRhb
Copy link
Member

JKRhb commented Apr 16, 2022

coapjs/node-coap#333 has now been merged :) Hope everything is now working again.

@danielpeintner
Copy link
Member Author

I reverted 897d3dd and used the latest coap version with new issues.

see #728 (comment)

Hence, I suggest to merge this PR as is and go on with CoAP issues in #728

@JKRhb
Copy link
Member

JKRhb commented Apr 19, 2022

I reverted 897d3dd and used the latest coap version with new issues.

see #728 (comment)

Hence, I suggest to merge this PR as is and go on with CoAP issues in #728

That sounds good :) I am going to investigate the new (pretty strange) issue in the meantime

@danielpeintner danielpeintner merged commit dbe62fa into eclipse-thingweb:master Apr 19, 2022
@danielpeintner danielpeintner deleted the increase-version-8-0-1 branch May 24, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants