-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: increase version to 0.8.1 and fix dependency issues with TMs, CoAP, OPC-UA #727
chore: increase version to 0.8.1 and fix dependency issues with TMs, CoAP, OPC-UA #727
Conversation
I would not merge this PR without fixing the 2 issues first, commenting tests out is not a good idea; |
fix(binding-opcua): fix node-opcua module mistmatch
@erossignon Thanks for the fix! I do have some questions now
|
IMHO, they should but not everybody follows this convention 😢
Maybe npm-update what we are looking for.
my takeaway from this experience is that before release we should update all the dependencies to the latest version. In my understanding dependants libraries will not follow the package-lock constraints and if they install node-wot right after the release they will download the latest version of our dependencies.
I did some tests locally and I didn't encounter any problems. But I'm not against to have more frequent releases 👍🏻 |
I suggest to wait for coapjs/node-coap#333 to land. This would bring as back to "normal" again |
Note: since we are introducing some breaking changes in #731 @relu91 is suggesting to jump to v0.9.0 EDIT: One downside is a bit that we loose the connection between "wot-typescript-definitions" versioning |
coapjs/node-coap#333 has now been merged :) Hope everything is now working again. |
I reverted 897d3dd and used the latest coap version with new issues. see #728 (comment) Hence, I suggest to merge this PR as is and go on with CoAP issues in #728 |
That sounds good :) I am going to investigate the new (pretty strange) issue in the meantime |
No description provided.