-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up examples #618
Clean up examples #618
Conversation
I looked at the examples and I think we should clean-up the package a bit. There are many samples in that I think can be removed. I rather prefer having a couple of examples but those should serve a good use-case and should be up-to -date. Question to everybody. "What" are the examples we should keep?
Opinions are welcome! |
@relu91 @egekorkan @JKRhb @wiresio @sebastiankb others? Do you have comments to #618 (comment) above? I would like to clean-up (remove?) unneeded parts and concentrate on some good examples and keep them in sync as best as we can... |
Agreeing on this
Can and should be removed |
should go into its own directory if necessary
+ counter example updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I totally agree with having a smaller pool of well-maintained examples.
However, it might be tricky to have protocol-specific examples inside the binding package. Examples usually have dependencies with the cli package and a binding-package does not need it. My opinion is that we should still use the examples package even for protocol binding specific examples.
My suggestion is to go ahead with this PR and start thinking about a structure for protocol-specific examples. Almost all of them just re-implement the default servient using the binding and provide a simple TD. Maybe with a more flexible CLI we can factor out most of the code that is currently in the binding examples.
No description provided.