Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up examples #618

Merged

Conversation

danielpeintner
Copy link
Member

No description provided.

@danielpeintner danielpeintner marked this pull request as draft November 9, 2021 16:28
@danielpeintner
Copy link
Member Author

danielpeintner commented Nov 9, 2021

I looked at the examples and I think we should clean-up the package a bit. There are many samples in that I think can be removed. I rather prefer having a couple of examples but those should serve a good use-case and should be up-to -date.

Question to everybody. "What" are the examples we should keep?

Opinions are welcome!

@danielpeintner danielpeintner mentioned this pull request Jan 13, 2022
8 tasks
@danielpeintner
Copy link
Member Author

@relu91 @egekorkan @JKRhb @wiresio @sebastiankb others?

Do you have comments to #618 (comment) above?

I would like to clean-up (remove?) unneeded parts and concentrate on some good examples and keep them in sync as best as we can...

@egekorkan
Copy link
Member

  • Are all other samples needed? mqtt, modbus, opcua, netconf, mbus (shouldn't we put most of them in the according binding?)

Agreeing on this

  • servients

Can and should be removed

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I totally agree with having a smaller pool of well-maintained examples.

However, it might be tricky to have protocol-specific examples inside the binding package. Examples usually have dependencies with the cli package and a binding-package does not need it. My opinion is that we should still use the examples package even for protocol binding specific examples.

My suggestion is to go ahead with this PR and start thinking about a structure for protocol-specific examples. Almost all of them just re-implement the default servient using the binding and provide a simple TD. Maybe with a more flexible CLI we can factor out most of the code that is currently in the binding examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants