Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove eslint for browser-bundle #597

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

danielpeintner
Copy link
Member

No description provided.

@danielpeintner
Copy link
Member Author

Note: I suggest to remove eslint for the one index.js file.

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed feeling about this:

  • Linting one script with about 20 lines of code is a little bit overkill
  • What if the script will grown into something bigger?

Since I don't have a clear opinion about this I think we can move on and maybe re-enable it later. @danielpeintner the ball is yours 😄

@danielpeintner
Copy link
Member Author

  • Linting one script with about 20 lines of code is a little bit overkill

Exactly. No need, at least at the moment.
Moreover, the current setup seems to expect ts files and fails for the browser-bundle.

...\packages\browser-bundle\index.js
  0:0  error  Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: packages\browser-bundle\index.js.
The file must be included in at least one of the projects provided
  • What if the script will grown into something bigger?

We can still brink it back if we feel there is the necessity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants