-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(coap): fix eslint issues #588
Conversation
46a8ae1
to
71848cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to add
// eslint-disable-next-line @typescript-eslint/no-explicit-any
before the any
warnings and note down the files in
#534
I know we are somewhat cheating but I guess as long as we keep track of the ignored rules it is fine and we can check from time to time whether more ignored rules can be resolved...
Note: running
|
In my understanding, once we have #538 ready to go, we will have also typings for those any variables. So I would keep the warning if you don't really mind. I guess your concerns are for the CI red flags, right? |
Exactly, I hope that the new version of node-coap is going to be ready soon (unfortunately, the release process is a bit delayed at the moment). Therefore, I would tend to keep the warnings as temporary reminders as well but I can also add the ignore statements if you prefer them, @danielpeintner. |
This is a temporary workaround until eclipse-thingweb#538 is ready.
Yes :-) Either way is fine! |
I now added a commit for explicitly ignoring the |
Thanks, I added it to #534 |
This PR fixes a number of eslint issues in the
binding-coap
package (also see #586). Due to the fact that are no typescript bindings fornode-coap
yet someany
typings couldn't be removed yet. However, with the next version ofnode-coap
and the merge of #538 this will hopefully also be resolved eventually.I opened this PR as a draft for now due to some tests that failed locally.The issues should be fixed now :)