Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(binding-opcua) fix binding-opcua #537

Merged

Conversation

erossignon
Copy link
Contributor

@erossignon erossignon commented Sep 27, 2021

  • improve test
  • refactor to 0.8.0 api
  • improve typescript compliance (avoid using any)
  • fix resource leaks
  • properly terminate servr
  • prevent too many subscriptions to be created.
  • do not use opaque nodeIds (I.e ns=1;b=ABCDFE) anymore => to prevent clash with breaking changes in [email protected]

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to opc-ua implementation! About the stop method, I agree it should be async, it is something that we need to fix.

@danielpeintner danielpeintner merged commit b22b8c2 into eclipse-thingweb:master Sep 28, 2021
@danielpeintner
Copy link
Member

Unfortunately we do have test issues with OPCUA now, see

https://github.com/danielpeintner/thingweb.node-wot/runs/3732161234?check_suite_focus=true

@erossignon do you have an idea what is causing this issues?

@erossignon
Copy link
Contributor Author

erossignon commented Sep 28, 2021

@erossignon do you have an idea what is causing these issues?

On some slow VM, the data change monitoring events are not guaranteed to be sent by the server one after the other.
This causes some flaky behavior, I have created a PR to take this into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants