refactor: align with eslint rules #2

[fatadel]

The second portion of eslint alignments (previous one - #511).

Signed-off-by: fatadel [email protected]

[danielpeintner]

Thanks @fatadel !
Can you also run npm run format to fix the coding style issues...

[relu91]

Small changes, but it looks good!

[relu91]

For logging we need to use our convention, I am wondering if we can enforce it somehow with eslint 🤔

[fatadel]

What do you mean by "our convention"?
I hope you've understood that I've added that code because of this rule - https://eslint.org/docs/rules/handle-callback-err.

[danielpeintner]

If you take a look at our packages and the console logs you will notice that we add a prefix to the error so that we can easily detect from which binding the error came from...

e.g.,

https://github.com/danielpeintner/thingweb.node-wot/blob/59fe3264bb4cfa19a3c8cddb0f1c68b4685a4a47/packages/binding-coap/src/coap-server.ts#L72-L74

[relu91]

yes exactly, can you add that prefix, please? :)

[fatadel]

Aah okay, sure! I thought you mean there is some kind of convention for the way we handle callback errors.

Will be fixed now 😊

[danielpeintner]

I don't think so. It is used elsewhere in the file also. Or do I miss anything?

[relu91]

I've fixed it. But a short question - won't there be a problem with referencing this?

Actually, he might be right, cause the whole code is wrapped inside function in this case if I recall correctly this points to the function object. @fatadel can you do a couple of tests with a small script reproducing the situation? Then we can merge this! 😃

[relu91]

while I was here I did the test myself 😄 :

class Test {
    constructor() {
        this.title = "Test";
    }
    testMeFunction(){
        setInterval( function () {
            console.log("function", this.title);
        }, 1000);
    }

    testMeArrow() {
        setInterval( () => {
            console.log("arrow",this.title);
        }, 1000);
    }
}

new Test().testMeFunction();
new Test().testMeArrow();

output:

function undefined
arrow Test
function undefined
arrow Test
function undefined

arrow Test

Consequently, I'd ask @fatadel to change function into an arrow function :)

[danielpeintner]

Note: I guess we need to check other places than also...

[fatadel]

@relu91, done!
Should I also check for this inside functions in other places or let's leave it for a separate PR?

[fatadel]

npm run format

Didn't know about this, thank you!

[fatadel]

Thanks @fatadel !
Can you also run npm run format to fix the coding style issues...

Done ✅

[danielpeintner]

@relu91 do you see any more issues to be resolved?

[relu91]

Looks good let's move on.