refactor: create helper function structuredClone and use *old* way

[danielpeintner]

point all functions to it so that in future we can easily update

fixes #1252

[danielpeintner]

Note: in package td-tools we use JSON.parse(JSON.stringify()) also but I don't think the helper functions belongs to td-tools package.

node-wot/packages/td-tools/src/td-parser.ts

Line 222 in 1d2e67e

const copy = JSON.parse(JSON.stringify(thing));

Hence we can just use it in packages that depend on core.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.82%. Comparing base (1d2e67e) to head (102ee66).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1258      +/-   ##
==========================================
+ Coverage   77.80%   77.82%   +0.01%     
==========================================
  Files          84       84              
  Lines       17523    17532       +9     
  Branches     1781     1781              
==========================================
+ Hits        13634    13644      +10     
+ Misses       3854     3853       -1     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[relu91]

I'm not sure that we should add this if we are not 100% sure that this is a bug of the current supported Nodejs versions. From the issue is not clear if the submitter is just using and old version or not.

[danielpeintner]

I just feel it is not worth to keep the built-in structuredClone if it causes issues. After it was first introduced in #1105 we had to partly revert it in #1152 because of issues. Now we see new issues popping up.

Hence I think it is an improvement until it is better supported. Moreover, with this change we can easily update the code once we feel comfortable.
Anyhow, if others think we should not make the change it is fine by me also.

[relu91]

As pointed into the commiter call I'm ok merging this PR, it's just refectoring the code to have a single point where to update. We can refactor later if needed.