Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(octet-stream): correct limits for integer serialization and add tests #1219

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

derwehr
Copy link
Contributor

@derwehr derwehr commented Jan 18, 2024

I noticed that the limits for integer serialization are wrong and corrected them. Additionally, I added test for these limits.

Changes in octetstream-codec.ts

  • serializing 255 as unsigned integer with 8 bits failed, succeeds now;
  • serializing 127 as signed integer with 8 bits failed, succeeds new;

Changes in ContentSerdesTest.ts

  • added tests verifying that 255 as uint8, 127 and -128 as int8 succeed
  • added tests verifying that 256 and -1 asunit8, 128 and -129 as int8 fail

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c130878) 77.75% compared to head (47e9408) 77.77%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1219      +/-   ##
==========================================
+ Coverage   77.75%   77.77%   +0.02%     
==========================================
  Files          84       84              
  Lines       17444    17452       +8     
  Branches     1765     1766       +1     
==========================================
+ Hits        13564    13574      +10     
+ Misses       3844     3842       -2     
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielpeintner
Copy link
Member

I noticed that there is a style check issue. Can you run npm run format...

@danielpeintner
Copy link
Member

@relu91, @JKRhb, others
any more comments before integrating the PR?

@relu91 relu91 merged commit 450ebd9 into eclipse-thingweb:master Feb 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants