fix(octet-stream): correct limits for integer serialization and add tests #1219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the limits for integer serialization are wrong and corrected them. Additionally, I added test for these limits.
Changes in
octetstream-codec.ts
255
as unsigned integer with 8 bits failed, succeeds now;127
as signed integer with 8 bits failed, succeeds new;Changes in
ContentSerdesTest.ts
255
asuint8
,127
and-128
asint8
succeed256
and-1
asunit8
,128
and-129
asint8
fail