Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up octet-stream codec - short explanation #1194 #1209

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

derwehr
Copy link
Contributor

@derwehr derwehr commented Jan 2, 2024

I've added descriptions for the content type parameters and data schema terms of the octet-stream codec, and an example of how to describe an object with the new terms.

(related issue: #1194)

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (84327e3) 77.60% compared to head (7dd808d) 77.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1209      +/-   ##
==========================================
- Coverage   77.60%   77.56%   -0.05%     
==========================================
  Files          83       83              
  Lines       17311    17311              
  Branches     1747     1747              
==========================================
- Hits        13434    13427       -7     
- Misses       3841     3849       +8     
+ Partials       36       35       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JKRhb JKRhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following suggestions can be applied to get rid of the prettier errors – otherwise LGTM :)

packages/core/README.md Outdated Show resolved Hide resolved
packages/core/README.md Show resolved Hide resolved
packages/core/README.md Show resolved Hide resolved
packages/core/README.md Show resolved Hide resolved
@JKRhb JKRhb linked an issue Jan 7, 2024 that may be closed by this pull request
@derwehr
Copy link
Contributor Author

derwehr commented Jan 7, 2024

The following suggestions can be applied to get rid of the prettier errors – otherwise LGTM :)

Thanks for the review. I commited the suggested changes

Co-authored-by: danielpeintner <[email protected]>
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! good to go from my side.

@danielpeintner danielpeintner merged commit 5dc47c4 into eclipse-thingweb:master Jan 8, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow-up octet-stream codec - short explanation
4 participants