-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow-up octet-stream codec - short explanation #1194 #1209
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1209 +/- ##
==========================================
- Coverage 77.60% 77.56% -0.05%
==========================================
Files 83 83
Lines 17311 17311
Branches 1747 1747
==========================================
- Hits 13434 13427 -7
- Misses 3841 3849 +8
+ Partials 36 35 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following suggestions can be applied to get rid of the prettier errors – otherwise LGTM :)
Thanks for the review. I commited the suggested changes |
Co-authored-by: danielpeintner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! good to go from my side.
5dc47c4
into
eclipse-thingweb:master
I've added descriptions for the content type parameters and data schema terms of the
octet-stream
codec, and an example of how to describe an object with the new terms.(related issue: #1194)