fix(binding-modbus): clean up operations when timeout #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't clean up the queue and the application is looping trying to read modbus registers, the queue will grow indefinitely. This cleans up the queue when a timeout occurs (e.g. wrong remote host or not reachable).
relu91
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1173 +/- ##
==========================================
- Coverage 76.52% 76.33% -0.19%
==========================================
Files 80 80
Lines 16705 16829 +124
Branches 1616 1615 -1
==========================================
+ Hits 12784 12847 +63
- Misses 3891 3952 +61
Partials 30 30 ☔ View full report in Codecov by Sentry. |
danielpeintner
approved these changes
Nov 27, 2023
…n timeout If we don't clean up the queue and the application is looping trying to read modbus registers, the queue will grow indefinitely. This cleans up the queue when a timeout occurs (e.g. wrong remote host or not reachable).
danielpeintner
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't clean up the queue and the application is looping trying to read Modbus registers, the queue will grow indefinitely. This cleans up the queue when a timeout occurs (e.g. wrong remote host or not reachable).