Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable strictNullChecks globally #1126

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Oct 17, 2023

As another step towards resolving #1046, this PR enables strictNullChecks globally and removes it from individual packages that extend the global tsconfig.json file.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (595d818) 77.39% compared to head (6dde8d1) 77.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1126   +/-   ##
=======================================
  Coverage   77.39%   77.39%           
=======================================
  Files          80       80           
  Lines       16159    16159           
  Branches     1519     1519           
=======================================
  Hits        12506    12506           
  Misses       3632     3632           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JKRhb JKRhb changed the title refactor: enable strictNullChecks and strict-boolean-expressions globally refactor: enable strictNullChecks globally Oct 17, 2023
@JKRhb JKRhb marked this pull request as ready for review October 17, 2023 15:12
@JKRhb JKRhb changed the title refactor: enable strictNullChecks globally chore: enable strictNullChecks globally Oct 17, 2023
@danielpeintner
Copy link
Member

As another step towards resolving #1046, this PR enables strictNullChecks globally and removes it from individual packages that extend the global tsconfig.json file.

I am just wondering: Why do you say "another step towards resolving"?
If I understand this PR properly it resolves the issue, am I wrong?

Unless there are "strictNullChecks": false left in some packages.

@JKRhb
Copy link
Member Author

JKRhb commented Oct 17, 2023

I think the linked issue is mostly about the @typescript-eslint/strict-boolean-expressions linting rule, for which strictNullChecks are a pre-condition – but I am currently preparing a PR to also resolve that part :)

@relu91
Copy link
Member

relu91 commented Oct 19, 2023

Well done merging.

@relu91 relu91 merged commit 8f5b158 into eclipse-thingweb:master Oct 19, 2023
@JKRhb JKRhb deleted the strict branch October 19, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants