Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(binding-opcua): improve/stabilize tests #1120

Merged
merged 2 commits into from
Oct 13, 2023
Merged

chore(binding-opcua): improve/stabilize tests #1120

merged 2 commits into from
Oct 13, 2023

Conversation

danielpeintner
Copy link
Member

see #1072

JKRhb
JKRhb approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@JKRhb JKRhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted just a very minor typo, otherwise LGTM :)

packages/binding-opcua/test/full-opcua-thing-test.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@b44448b). Click here to learn what that means.
Report is 2 commits behind head on master.

❗ Current head 95ed97c differs from pull request most recent head 25f38a9. Consider uploading reports for the commit 25f38a9 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #1120   +/-   ##
=========================================
  Coverage          ?   75.67%           
=========================================
  Files             ?       80           
  Lines             ?    16159           
  Branches          ?     1519           
=========================================
  Hits              ?    12228           
  Misses            ?     3889           
  Partials          ?       42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielpeintner danielpeintner mentioned this pull request Oct 13, 2023
Closed
@danielpeintner @JKRhb
fix typo
25f38a9 
Co-authored-by: Jan Romann <[email protected]>
@danielpeintner danielpeintner merged commit 2e6fc09 into eclipse-thingweb:master Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@relu91 relu91 relu91 approved these changes

@JKRhb JKRhb JKRhb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielpeintner @relu91 @JKRhb