-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ts strict checking for binding mqtt #1053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKRhb
reviewed
Aug 9, 2023
Co-authored-by: Jan Romann <[email protected]>
…nto egekorkan-strict-mqtt
Codecov Report
@@ Coverage Diff @@
## master #1053 +/- ##
==========================================
- Coverage 75.54% 75.38% -0.17%
==========================================
Files 80 80
Lines 15341 15443 +102
Branches 1460 1477 +17
==========================================
+ Hits 11590 11641 +51
- Misses 3717 3766 +49
- Partials 34 36 +2
|
@danielpeintner should be ready to go. I think in this case we can squash and merge. |
danielpeintner
approved these changes
Aug 11, 2023
argh I forgot to squash :/ |
Thanks for doing it! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had started on this but did not manage to move forward due to time constraints. I still wanted to make it public so that others can take the work.
@hasanheroglu maybe you can have a quick look? Otherwise, I will try to get back to it in two weeks :)