Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme improvements #1043

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Readme improvements #1043

merged 2 commits into from
Aug 1, 2023

Conversation

egekorkan
Copy link
Member

@egekorkan egekorkan commented Jul 31, 2023

Mostly small changes such as:

  • NodeJS -> Node.js
  • the folder to change after cloning does not have thingweb anymore, i.e. cd node-wot instead of cd thingweb.node-wot
  • English typos and formulation (mostly highlighted by Grammarly)
  • Online Things indentation

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general however there are still appearances of "NodeJS" which should be replaced with "Node.js"

@egekorkan
Copy link
Member Author

Looks good in general however there are still appearances of "NodeJS" which should be replaced with "Node.js"

Done :)

@codecov-commenter
Copy link

Codecov Report

Merging #1043 (ea02ef7) into master (73bc53c) will increase coverage by 0.34%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1043      +/-   ##
==========================================
+ Coverage   75.43%   75.78%   +0.34%     
==========================================
  Files          80       80              
  Lines       15187    15303     +116     
  Branches     1434     1444      +10     
==========================================
+ Hits        11457    11597     +140     
+ Misses       3697     3673      -24     
  Partials       33       33              

see 1 file with indirect coverage changes

@danielpeintner danielpeintner merged commit b25d863 into eclipse-thingweb:master Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants