Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update TS definitions (24 May 2023) #1009

Merged
merged 1 commit into from
May 26, 2023

Conversation

danielpeintner
Copy link
Member

fixes #931 also

@danielpeintner danielpeintner requested a review from relu91 May 26, 2023 07:23
@codecov-commenter
Copy link

Codecov Report

Merging #1009 (72faad3) into master (badc223) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #1009   +/-   ##
=======================================
  Coverage   74.64%   74.64%           
=======================================
  Files          72       72           
  Lines       14882    14882           
  Branches     1412     1412           
=======================================
  Hits        11108    11108           
  Misses       3741     3741           
  Partials       33       33           

@danielpeintner
Copy link
Member Author

Question: See comment above. I can "enable" Codecov Report for alle eclipse-thingweb projects. Shall I do so?
@relu91 @egekorkan

@relu91
Copy link
Member

relu91 commented May 26, 2023

About code coverage, I belive it is a useful service so why not 😺 .

@relu91 relu91 merged commit c4312fe into eclipse-thingweb:master May 26, 2023
@danielpeintner
Copy link
Member Author

About code coverage, I belive it is a useful service so why not 😺 .

A request to install Codecov has been submitted on the @eclipse-thingweb account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove implicit dependency
3 participants