Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opcua binding compile test files into dist folder #599

Closed
relu91 opened this issue Oct 29, 2021 · 2 comments
Closed

Opcua binding compile test files into dist folder #599

relu91 opened this issue Oct 29, 2021 · 2 comments
Assignees
Labels
binding-opcua Issues related to opc ua protocol binding

Comments

@relu91
Copy link
Member

relu91 commented Oct 29, 2021

I assume here it is on purpose, right @erossignon?

Yes, having "rootdir": ".", dist:"dist" will cause ts file in src to go to dist/src and test to dist/test/.

The benefit is that the same tsconfig.json file is used for eslinting (in VSCode) the src and tst files ... It also allows us to check the syntax of the test file during the tsc -b phase.

the downside is that generated files are not stored in the dist folder anymore but one level below.

In our setup, it does not really make sense to compile test files into the dist folder, for two reasons:

  • It pollutes the distributed npm packages with files that will never be used
  • Tests are executed using ts-node

I think that also opc-ua binding should follow the same setup of other packages.

Originally posted by @relu91 in #598 (comment)

@relu91 relu91 added the binding-opcua Issues related to opc ua protocol binding label Oct 29, 2021
@erossignon
Copy link
Contributor

I'll take it.

erossignon added a commit to node-opcua/thingweb.node-wot that referenced this issue Oct 29, 2021
erossignon added a commit to node-opcua/thingweb.node-wot that referenced this issue Oct 29, 2021
erossignon added a commit to node-opcua/thingweb.node-wot that referenced this issue Nov 4, 2021
@relu91
Copy link
Member Author

relu91 commented Nov 4, 2021

Fixed in #600

@relu91 relu91 closed this as completed Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding-opcua Issues related to opc ua protocol binding
Projects
None yet
Development

No branches or pull requests

2 participants