fix(binding-coap): prevent resource leak

eclipse-thingweb · Sep 21, 2021 · 905596f · 905596f
1 parent 9f350c5
commit 905596f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/packages/binding-coap/src/coap-client.ts b/packages/binding-coap/src/coap-client.ts
@@ -178,7 +178,7 @@ export default class CoapClient implements ProtocolClient {
     }
 
     public stop(): boolean {
-        // FIXME coap does not provide proper API to close Agent
+        this.agent.close();
         return true;
     }
 

diff --git a/packages/binding-coap/test/coap-client-test.ts b/packages/binding-coap/test/coap-client-test.ts
@@ -98,7 +98,9 @@ class CoapClientTest {
                     return coapServer.stop();
                 })
                 .then(() => {
-                    done();
+                    coapServer.stop().then(() => {
+                        done();
+                    });
                 });
         });
     }

diff --git a/packages/binding-http/test/http-client-test.ts b/packages/binding-http/test/http-client-test.ts
@@ -13,7 +13,6 @@
  * SPDX-License-Identifier: EPL-2.0 OR W3C-20150513
  ********************************************************************************/
 
-/* eslint-disable @typescript-eslint/no-var-requires */
 /**
  * Protocol test suite to test protocol implementations
  */
-Original file line number
+Diff line change
@@ Expand Up / @@ -98,7 +98,9 @@ class CoapClientTest { @@
                         return coapServer.stop();
                     })
                     .then(() => {
-                        done();
+                        coapServer.stop().then(() => {
+                            done();
+                        });
                     });
             });
         }
@@ Expand Down @@