fix: replace generic with concrete Exceptions

eclipse-thingweb · Jan 18, 2022 · 4f1bfb8 · 4f1bfb8
1 parent 9961973
commit 4f1bfb8
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/lib/src/core/wot.dart b/lib/src/core/wot.dart
@@ -38,8 +38,7 @@ class WoT implements scripting_api.WoT {
     if (_servient.addThing(newThing)) {
       return newThing;
     } else {
-      // TODO(falko17): We should probably use a custom exception type here.
-      throw Exception('Thing already exists: ${newThing.title}');
+      throw StateError('Thing already exists: ${newThing.title}');
     }
   }
 

diff --git a/lib/src/definitions/expected_response.dart b/lib/src/definitions/expected_response.dart
@@ -22,8 +22,7 @@ class ExpectedResponse {
 
   static String _parseContentType(dynamic contentType) {
     if (contentType is! String) {
-      // TODO(JKRhb): Define custom exceptions
-      throw Exception("contentType of response map is not a String!");
+      throw ArgumentError("contentType of response map is not a String!");
     }
     return contentType;
   }

diff --git a/lib/src/scripting_api/subscription.dart b/lib/src/scripting_api/subscription.dart
@@ -54,8 +54,7 @@ Form findUnsubscribeForm(InteractionAffordance interaction,
   final unsubscribeForm = _findFormByScoring(interaction, form, operationType);
 
   if (unsubscribeForm == null) {
-    // TODO(JKRhb): Add appropriate Exception type.
-    throw Exception("Could not find matching form for unsubscribe");
+    throw StateError("Could not find matching form for unsubscribe");
   }
 
   return unsubscribeForm;
@@ -68,7 +67,7 @@ String _determineOpType(SubscriptionType? subscriptionType) {
     case SubscriptionType.property:
       return "unobserveproperty";
     default:
-      throw Exception();
+      throw ArgumentError();
   }
 }