Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron: fix re-opening of electron window #9993

Closed
wants to merge 1 commit into from

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes: #9990.

The commit restores the previous window state (position and size) when re-opening an electron window, and also preserves the fix that avoids the electron window overlap. The idea is to use the previous windowstate when opening the window when a single window is found.

How to test

  1. start the example-electron application.
  2. resize the window, and move the window position.
  3. close the window, and re-open it - the size and position should be restored.
  4. open a new window (or folder) - there should be a proper overlap (not exactly on top of the other window(s)).

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

The commit restores the previous window state (position and size) when
re-opening an electron window, and also preserves the fix that avoids
the electron window overlap. The idea is to use the previous
`windowstate` when opening the window when a single window is found.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added the electron issues related to the electron target label Aug 30, 2021
@vince-fugnitto vince-fugnitto self-assigned this Aug 30, 2021
@vince-fugnitto
Copy link
Member Author

Still investigating if there is a cleaner more generic fix.

@ccorn
Copy link

ccorn commented Aug 30, 2021

A git cherry-pick origin/vf/electron-fix indeed has solved the issue for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron issues related to the electron target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Electron version does not restore window size
2 participants