monaco: restore drop-shadow
for quick-input
#9938
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The commit updates the styling of the
quick-input
to restore the drop-shadow which was previously present (and present in vscode) following the monaco upgrade. The drop-shadow helps to display the overlay especially when there is content behind such as an editor, and it aligns with our previous styling and that of vscode.before:
drop-before.mov
after:
drop-after.mov
How to test
quick-input
(ex: F1)run task...
)Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]