Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monaco: restore drop-shadow for quick-input #9938

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Aug 20, 2021

What it does

The commit updates the styling of the quick-input to restore the drop-shadow which was previously present (and present in vscode) following the monaco upgrade. The drop-shadow helps to display the overlay especially when there is content behind such as an editor, and it aligns with our previous styling and that of vscode.

before:

drop-before.mov

after:

drop-after.mov

How to test

  1. start the application, and trigger a quick-input (ex: F1)
  2. confirm that the quick-input has a drop-shadow applied, similarly to vscode and that master did not
  3. confirm the same for quick-pick (ex: run task...)

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

The commit updates the styling of the `quick-input` to restore the
drop-shadow which was previously present (and present in vscode)
following the monaco upgrade.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added monaco issues related to monaco ui/ux issues related to user interface / user experience labels Aug 20, 2021
@vince-fugnitto vince-fugnitto self-assigned this Aug 20, 2021
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Tested with different color themes and couldn't notice any visual difference to vscode.

@vince-fugnitto vince-fugnitto merged commit cbdfe8f into master Aug 20, 2021
@vince-fugnitto vince-fugnitto deleted the vf/quick-input-drop branch August 20, 2021 18:50
@github-actions github-actions bot added this to the 1.17.0 milestone Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monaco issues related to monaco ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants