Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TaskDto conversion in $fetchTasks #9740

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

tsmaeder
Copy link
Contributor

Signed-off-by: Thomas Mäder [email protected]

What it does

Use the common conversion method on the main side when fetching tasks from a plugin. Fixes #9605

How to test

Instructions for reproducing the issue are in the linked issue above: make sure the behaviour is correct with the fix present.

Review checklist

Reminder for reviewers

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the issue exists on master and is addressed nicely by this change. Other tasks continue to work as expected.

@alvsan09
Copy link
Contributor

Hi @tsmaeder ,
Can you please check if this solution does not bring back #7982?

Copy link
Contributor

@caseyflynn-google caseyflynn-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed the repro steps in #9605 and confirmed this fixes the issue. Additionally, I ran a few tasks which seem to work properly.

@tsmaeder
Copy link
Contributor Author

@alvsan09 the code involved here is strictly related to how plugins see the tasks. So this change should not have any effect on the issue you mentioned.

@tsmaeder tsmaeder merged commit 6550934 into eclipse-theia:master Jul 26, 2021
@vince-fugnitto vince-fugnitto added this to the 1.16.0 milestone Jul 29, 2021
dna2github pushed a commit to dna2fork/theia that referenced this pull request Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User defined tasks are not revealed when these are executed programmatically
5 participants