Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import of is-electron (#9729) #9730

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

planger
Copy link
Contributor

@planger planger commented Jul 13, 2021

Fix #9729

Signed-off-by: Philip Langer [email protected]

What it does

This change replaces the import is-electron with a require to workaround the error

root ERROR Error starting the debug session TypeError: is_electron_1.default is not a function
    at Object.startDebugAdapter (/home/philip/Git/OpenSource/Theia/theia/packages/plugin-ext/lib/plugin/node/debug/plugin-debug-adapter-starter.js:44:48)
    at DebugExtImpl.<anonymous> (/home/philip/Git/OpenSource/Theia/theia/packages/plugin-ext/lib/plugin/node/debug/debug.js:725:82)
    at step (/home/philip/Git/OpenSource/Theia/theia/packages/plugin-ext/lib/plugin/node/debug/debug.js:33:23)
    at Object.next (/home/philip/Git/OpenSource/Theia/theia/packages/plugin-ext/lib/plugin/node/debug/debug.js:14:53)
    at fulfilled (/home/philip/Git/OpenSource/Theia/theia/packages/plugin-ext/lib/plugin/node/debug/debug.js:5:58)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

How to test

Please follow the steps to reproduce documented in #9729 and check the console that the error above doesn't occur.

Review checklist

Reminder for reviewers

@planger
Copy link
Contributor Author

planger commented Jul 13, 2021

Thanks a lot for the fast review @paul-marechal!

@paul-marechal
Copy link
Member

It's a trivial change and looking at how the package is implemented vs its declaration it makes a lot of sense.

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error starting the debug session TypeError: is_electron_1.default is not a function
3 participants