Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-resource-dir-name-and-resource-path: #9499

Conversation

danarad05
Copy link
Contributor

Signed-off-by: Dan Arad [email protected]

What it does

  1. add resourceDirName and resourcePath to contextkeys (see https://code.visualstudio.com/updates/v1_50#_added-new-resource-explorerrelated-context-keys)

How to test

  1. Either debug resource-context-key.ts in Theia when opening a resource
    image

  2. Retrieve context or contextkeyvalues
    image

Review checklist

Reminder for reviewers

add resourceDirName and resourcePath to contextkeys

Signed-off-by: Dan Arad <[email protected]>
@danarad05
Copy link
Contributor Author

@offer8

@danarad05
Copy link
Contributor Author

@vince-fugnitto could you assign a reviewer for this PR?
Thanks

@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label May 25, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the changes work as expected:

Examples (works for undefined, folder or file):

root INFO set 'resource-context-key' ------------
root INFO       resourceDirName: undefined
root INFO       resourcePath: undefined
root INFO set 'resource-context-key' ------------
root INFO       resourceDirName: /workspace/theia
root INFO       resourcePath: /workspace/theia/configs
root INFO set 'resource-context-key' ------------
root INFO       resourceDirName: /workspace/theia
root INFO       resourcePath: /workspace/theia/yarn.lock

@vince-fugnitto
Copy link
Member

@danarad05 I believe the following can be added to the release, I confirmed it works well.

@colin-grant-work colin-grant-work merged commit 55b55ee into eclipse-theia:master Jun 17, 2021
@vince-fugnitto vince-fugnitto added this to the 1.15.0 milestone Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants