Bumped deepmerge to 4.2.2.
#9405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittaakos
referenced
this pull request
in arduino/arduino-ide
Apr 27, 2021
Signed-off-by: Akos Kitta <[email protected]>
vince-fugnitto
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
The changes look good to me 👍 I verified that:
- the updated dependency is license compliant using the compliance procedure.
@theia/monacono longer needsdeepmerge.- performed sanity checks and the application still starts correctly.
vince-fugnitto
added
the
dependencies
paul-marechal
force-pushed
the
update-deepmerge
branch
2 times, most recently
from
9bbca9e to
5402ed2
Compare
- Removed the obsolete dependency from `@theia/monaco.` - Switched from `require` to ES `import`. Signed-off-by: Akos Kitta <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
paul-marechal
force-pushed
the
update-deepmerge
branch
from
5402ed2 to
3f36847
Compare
RomanNikitenko
pushed a commit
that referenced
this pull request
Sep 16, 2021
- Removed the obsolete `deepmerge` dependency from `@theia/monaco`. - Switched from raw `require` to proper TS import. Signed-off-by: Akos Kitta <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
RomanNikitenko
pushed a commit
that referenced
this pull request
Sep 16, 2021
- Removed the obsolete `deepmerge` dependency from `@theia/monaco`. - Switched from raw `require` to proper TS import. Signed-off-by: Akos Kitta <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@theia/monaco.requireto ESimport.Signed-off-by: Akos Kitta [email protected]
What it does
deepmergeversion,requireto ESimport, anddeepmergefrom@theia/monaco.How to test
yarn why deepmerge.Review checklist
Reminder for reviewers