Fix #5812, Replacing a magic number with its css variable #9197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: beyzahizli <[email protected]>
vince-fugnitto
added
quality
vince-fugnitto
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Beyza Hizli [email protected]
What it does
Fixes: #5812
This pull request fixes issue #5812. The requested variable is already introduced and used, but one instance of the magic number was missed, which is refactored now.
How to test
I followed the 'how to test' guide from this pull request #8870 and inspected the reviewer comment:
It is still correctly applying the line-height.
Review checklist
Reminder for reviewers