documentation: update individual extension readmes #8279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcdumais-work
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
LGTM, thanks @vince-fugnitto . This brings down to just a couple the extensions that do not yet follow the README template: core and filesystem.
- the following commit updates individual extension readmes to include `Eclipse Theia` instead of `Theia` following the foundation rules. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/eclipse-name
branch
from
0270c21 to
8162e33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The following pull-request updates the individual extension readmes to refer to Eclipse Theia rather than Theia as per the Eclipse Foundation first-mention rule. Since the readmes are displayed on
npm, they would require the nameEclipseas it is a first-mention.The pull-request also includes updates to the following extensions to use the template:
@theia/api-samples@theia/ext-scriptsHow to test
Verify the content of the documentation.
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]