always use CommandService.execute to run a command

[akosyakov]

What it does

• fix plugins are not activated if a command is triggered via keybindings #7324: keybindins and monaco were directly running command handlers before, because of it command listeners as onWillExecute were never triggered and the plugin system could not active plugins
• fix Extend Theia Extensions to support onWillExecute and onDidExecute listeners #7270: onDidExecute is added to support Monaco APIs properly

How to test

• Trigger Find All References with a keybiding from ts file
• Reference Search view should be opened and when ts is finished initialization references should appear
• There should not be exception in logs that a command handler was not found as before.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

I was able to successfully trigger find all references using the keybinding (which was not possible on master) 👍

I did notice a future improvement, which is to display the keybinding for commands contributed by VS Code extensions (shift+alt+F12)

[akosyakov]

I did notice a future improvement, which is to display the keybinding for commands contributed by VS Code extensions (shift+alt+F12)

@vince-fugnitto not sure why it is not in the context menu, but i see it in the quick command palette. Could you file a follow-up issue please?

[vince-fugnitto]

I did notice a future improvement, which is to display the keybinding for commands contributed by VS Code extensions (shift+alt+F12)

@vince-fugnitto not sure why it is not in the context menu, but i see it in the quick command palette. Could you file a follow-up issue please?

#7327

[kittaakos]

Please update the changelog with the breaking API changes. Thanks!

[akosyakov]

@kittaakos What is breaking?

[kittaakos]

What is breaking?

For instance: https://github.com/eclipse-theia/theia/pull/7326/files#diff-ab6e2d4c57658cf60e550cfe9ba87eacR304

[kittaakos]

Here is another: https://github.com/eclipse-theia/theia/pull/7326/files#diff-d284be88aa06fd2706aeac668e61375aR291

[akosyakov]

For instance: https://github.com/eclipse-theia/theia/pull/7326/files#diff-ab6e2d4c57658cf60e550cfe9ba87eacR304

I can, but i don't think it is practical. I am pretty sure that it is only client.

Here is another: https://github.com/eclipse-theia/theia/pull/7326/files#diff-d284be88aa06fd2706aeac668e61375aR291

How is it going to break? It is a new field which is only used by CommandRegistry. Do you know anyone reimplementing CommandRegistry?

[akosyakov]

Here is another: https://github.com/eclipse-theia/theia/pull/7326/files#diff-d284be88aa06fd2706aeac668e61375aR291

Actually, it is not related to our CommandRegistry. It is exposing Monaco internals API. It was there always and noone except our implementation of Monaco context menu is using it.

[akosyakov]

@kittaakos I've made args optional, if it is turned out that someone called fireWillExecute method. For Monaco I don't think we need to log any breaking changes. It is a glue code between Theia and monaco internals.