Consistently show ellipsis in place of overflowing tree content #7162
Conversation
vince-fugnitto
added
the
ui/ux
|
@vince-fugnitto It looks like a breaking change, also |
Ahh I see what you mean. I think the |
|
@garethwhittaker I think you can limit the change to trees contributed by |
|
👍 @vince-fugnitto let me know if this change looks suitable. |
There was a problem hiding this comment.
The change fixes the issue with the tree-views and does not affect any extended trees (from core). @akosyakov are you fine with this approach?
|
Does it mean that there is no way to restyle it without introducing new classes? Why it does not break other trees? |
| @@ -38,3 +38,9 @@ | |||
| align-items: center; | |||
| height: 100%; | |||
| } | |||
|
|
|||
| .theia-TreeNodeSegmentEllipsis { | |||
There was a problem hiding this comment.
it should be .theia-tree-view .theia-TreeNodeSegmentEllipsis
Fixes: #7145 Signed-off-by: Gareth Whittaker <[email protected]>
|
Is it still relevant after #7237. I believe the proper solution is similar to #7237 (comment) |
Thank you for the fix @garethwhittaker, however, it looks like the pull-request #7237 has already fixed the issue with a proper solution. We look forward to future contributions 😃 |
What it does
Fixes: #7145
The styling of overflowing tree content is currently inconsistent. An example of this is shown in the screenshot below.
An ellipsis should now be shown in place of overflowing content in all tree views.
How to test
Open a project and reduce the width of the tree view until content would extend beyond the available space. In all tree views an ellipsis should replace the overflowing content.
Include the Git Lens extension in this testing (#6921)
Review checklist
Reminder for reviewers