Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

about: enhancement to use application name in title #7135

Merged
merged 1 commit into from
Feb 13, 2020
Merged

about: enhancement to use application name in title #7135

merged 1 commit into from
Feb 13, 2020

Conversation

Anasshahidd21
Copy link
Contributor

@Anasshahidd21 Anasshahidd21 commented Feb 11, 2020 •
edited by vince-fugnitto
Loading

What it does

Fixes: #7130

The pull-request updates the AboutDialog to use the full applicationName as a title.
If an application's applicationName is not provided the default name is Theia.

Signed-off-by: Muhammad Anas Shahid [email protected]

How to test

  1. start the application
  2. in the main-menu, select Help > About
  3. the dialog should correctly display the applicationName as it's title

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added dialogs issues related to dialogs enhancement issues that are enhancements to current functionality - nice to haves labels Feb 11, 2020
vince-fugnitto
vince-fugnitto approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed that the full applicationName as a title when displaying the AboutDialog 👍

Screen Shot 2020-02-12 at 8 27 53 AM

lmcbout
lmcbout approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@lmcbout lmcbout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Thanks @Anasshahidd21

@vince-fugnitto
Copy link
Member

@Anasshahidd21 do you mind rebasing the pull-request?

about: enhancement to use application name in title
311c67d 
Fixes: eclipse-theia#7130
It displays the name of the application as the header when opened

Signed-off-by: Muhammad Anas Shahid <[email protected]>
@Anasshahidd21
Copy link
Contributor Author

Anasshahidd21 commented Feb 13, 2020 •
edited
Loading

@Anasshahidd21 do you mind rebasing the pull-request?

@vince-fugnitto Done, you can check.

@vince-fugnitto vince-fugnitto merged commit 7729776 into eclipse-theia:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmcbout lmcbout lmcbout approved these changes

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
dialogs issues related to dialogs enhancement issues that are enhancements to current functionality - nice to haves
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

about: enhancement to use application name in title
3 participants
@Anasshahidd21 @vince-fugnitto @lmcbout